Skip to content

Enable short-ice for Windows #142844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Enable short-ice for Windows #142844

wants to merge 1 commit into from
+8 −4

Conversation

dpaoliello
Copy link
Contributor

@dpaoliello dpaoliello commented Jun 21, 2025 •
edited
Loading

Works fine with MSVC without modifications.

Addresses item in #128602

x86_64-mingw-*
x86_64-msvc-*
try-job: i686-msvc-*

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

This PR modifies run-make tests.

cc @jieyouxu

@Noratrieb
Copy link
Member

Noratrieb commented Jun 21, 2025 •
edited
Loading

(does bors2 support try-jobs in the description or only in the command? let's see. looks like it does!)
@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 21, 2025

⌛ Trying commit ac55186 with merge b3a3974…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 21, 2025
@rust-bors
Auto merge of #142844 - dpaoliello:short-ice, r=<try>
b3a3974 
Enable short-ice for Windows

Works fine with MSVC without modifications.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

💔 Test failed

@jieyouxu
Copy link
Member

@bors2 delegate=try

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

@dpaoliello can now perform try builds on this pull request

@jieyouxu
Copy link
Member

I vaguely remember this, maybe the backtrace is somehow different in i686 msvc?
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@dpaoliello dpaoliello marked this pull request as draft June 23, 2025 19:36
@dpaoliello
Copy link
Contributor Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

⌛ Trying commit a303bed with merge 86d5cbc…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 23, 2025
@rust-bors
Auto merge of #142844 - dpaoliello:short-ice, r=<try>
86d5cbc 
Enable short-ice for Windows

Works fine with MSVC without modifications.

Addresses item in #128602

---

x86_64-mingw-*
x86_64-msvc-*
try-job: i686-msvc-*
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

💔 Test failed

@dpaoliello
Copy link
Contributor Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

⌛ Trying commit 9e45323 with merge b01f6f1…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 23, 2025
@rust-bors
Auto merge of #142844 - dpaoliello:short-ice, r=<try>
b01f6f1 
Enable short-ice for Windows

Works fine with MSVC without modifications.

Addresses item in #128602

---

x86_64-mingw-*
x86_64-msvc-*
try-job: i686-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

💔 Test failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpaoliello @rustbot @Noratrieb @jieyouxu @rust-log-analyzer